Re: neo-modern-voice?

[Neil Puttock]

2009/10/16 Frédéric Bron <address@hidden>:
> I would like to submit a patch that adds two new accidental styles:
> neo-modern-voice and neo-modern-voice-cautionary.

LGTM.

+
address@hidden
+\include "english.ly"
+
+musicA = \relative c' {
+       cs4 cs gs' gs cs cs c, c g' g c c r2
+}
+musicB = \relative c' {
+       r2 cs4 cs gs' gs cs cs c, c g' g c c
+}
+
+{
+       #(set-accidental-style 'neo-modern-voice)
+       << \musicA \\ \musicB >>
+}
address@hidden lilypond
+

Why not use the existing snippet to demonstrate the new styles?

+      ((equal? style 'neo-modern-voice)
+       (set-accidentals-properties #f
+        `(
+          Voice , (make-accidental-rule 'same-octave 0),
(make-accidental-rule 'any-octave 0), (make-accidental-rule
'same-octave 1), neo-modern-accidental-rule
+          Staff , (make-accidental-rule 'same-octave 0),
(make-accidental-rule 'any-octave 0), (make-accidental-rule
'same-octave 1), neo-modern-accidental-rule
+        )
+        '()
+        context))
+      ((equal? style 'neo-modern-voice-cautionary)
+       (set-accidentals-properties #f
+        `(Voice , (make-accidental-rule 'same-octave 0))
+        `(
+          Voice , (make-accidental-rule 'any-octave 0),
(make-accidental-rule 'same-octave 1), neo-modern-accidental-rule
+          Staff , (make-accidental-rule 'same-octave 0),
(make-accidental-rule 'any-octave 0), (make-accidental-rule
'same-octave 1), neo-modern-accidental-rule
+        )
+        context))

Indentation/code style (format in the same manner as the other styles).

Regards,
Neil