Re: Make define-builtin-markup{,-list}-command #:category #:properties keywords (issue160048)

[Carl Sorensen]

On 12/3/09 9:14 AM, "address@hidden" <address@hidden> wrote:


> http://codereview.appspot.com/160048/diff/4008/6007#newcode131
> scm/markup.scm:131: ;; Register the new function, for markup
> documentation
> On 2009/12/03 14:58:38, nicolas.sceaux wrote:
>> I still have the feeling that user defined commands should not modify
> variables
>> from (lily) module.
>> Could there be e.g. a module check, so that the macro expand into the
>> documentation related settings only for builtin commands?
> 
> I think it would be more transparent if the documentation selection was
> turned off completely by default, and a documentation generating run
> explicitly turned it on.
> 
> If a user wants to make a small manual for his private markups, being
> not allowed to do so because of not being in the lily module would be a
> nuisance.  As would be having all lily markups in this manual.
> 
> A reasonably easy interface would be to use hashq-set! only
> when the respective entity happens to be a hashtable, or even anything
> other than #f.
> 
> I have not yet done anything in that respect since I have no idea yet
> where to properly place the code turning on/off the documentation
> collection.
> 

How about scm/document-markup.scm?

Carl