lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Make define-builtin-markup{,-list}-command #:category #:properties


From: dak
Subject: Re: Make define-builtin-markup{,-list}-command #:category #:properties keywords (issue160048)
Date: Thu, 17 Dec 2009 11:23:04 +0000

On 2009/12/05 10:52:52, nicolas.sceaux wrote:
Le 5 déc. 2009 à 09:48, mailto:address@hidden a écrit :

> Currently I don't see a better way forward than using a special
command
> line option, something like -dindex-markup on documentation runs.
> If I get no objections, I'll try making a patch for that.

Using a LilyPond option was also what I was about to propose, so
please go ahead.

Well, patch set 7 does that, but after rethinking this, I suppose I'd
call it a mistake.  Even if the option gets implemented for other
constructs than markup, the time and memory savings are likely
negligible.  Checking for the option is likely causing more overhead
than registering some markup.

This would only start making sense if all other indexing operations (not
just markup) were suppressed except on documentation runs.  I don't
think thta significant savings would be the result, and this would
completely leave the scope of this particular patchset and its aim.

So my take would be to apply patch set 6, and possibly file a TODO item
"just index markup, macros, whatever on documentation runs" with low
priority that may refer to this discussion and/or patch set 7.

A complete job would have to mess with indexing in C code if I am not
mistaken.  And there is no sense in a half-baked job like that of  patch
set 7 since markup is just a small part of the job.

http://codereview.appspot.com/160048

reply via email to

[Prev in Thread] Current Thread [Next in Thread]