lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix STEPMAKE_GET_VERSION for OpenBSD


From: Jan Nieuwenhuizen
Subject: Re: Fix STEPMAKE_GET_VERSION for OpenBSD
Date: Tue, 15 Dec 2009 21:19:54 +0100

Op dinsdag 15-12-2009 om 20:01 uur [tijdzone +0100], schreef Matthias
Kilian:
> On Tue, Dec 15, 2009 at 04:33:14PM +0100, Jan Nieuwenhuizen wrote:

> > It would be nice to know why we need this, esp. as this fix
> > does not make the logic more readible.
> 
> Not necessary, I aready had a closer look. It's failing in grep(1)
> for \|, which is undefined by POSIX (for basic regular expressions) and
> obviously support by GNU grep but not by OpenBSDs grep.

Ah, that makes sense.  Great, thanks!

> An alternative diff, which just adds some linebreaks and avoids line
> continuations using backslash-newline: (for improving readability a
> little bit):

LGTM, please apply.

[either one, I also like the second one-command-a-line
one best].

Greetings,
Jan.







reply via email to

[Prev in Thread] Current Thread [Next in Thread]