lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: lily-git: amending patches


From: Carl Sorensen
Subject: Re: lily-git: amending patches
Date: Thu, 31 Dec 2009 20:55:20 -0700



On 12/31/09 8:27 PM, "Graham Percival" <address@hidden> wrote:

> On Thu, Dec 31, 2009 at 3:27 PM, Carl Sorensen <address@hidden> wrote:
>> 
>> I took an intermediate approach.  The extra button isn't "un-commit", it's
>> "wrap the current changes into the previous commit".  There isn't as much
>> flexibility as the "un-commit" button, but it should handle the hypothetical
>> situation quite well.
> 
> Ok.  I'm happy with the described functionality (sorry, ran out time
> to test it), but not the UI -- we don't want users to do 1. 2. 3. 4.
> under the current UI.
> 
> I toyed with having 1. 2a 2b 3. but it wasn't working for me.  I also
> briefly tried having a frame around 2a 2b, but couldn't figure out the
> tcl/tk commands in the time I allotted myself.

I pushed a version that stacks 2a and 2b vertically, so we go
  2a
1     3     Abort
  2b

I think I like it better.

It would be easy to stretch 1 3 and Abort vertically so they all took the
same space if that were preferred.

Thanks,

Carl






reply via email to

[Prev in Thread] Current Thread [Next in Thread]