Error in fretted-strings.itely? (was: Re: Enhancement: tabalture chord repetition (issue224082))

[Marc Hohl]

Marc Hohl schrieb:
> Nicolas Sceaux schrieb:
> > Le 1 mars 2010 à 10:00, Marc Hohl a écrit :
> >
> >  
> > > address@hidden schrieb:
> > >    
> > > > http://codereview.appspot.com/224082/diff/1/3
> > > > File ly/chord-repetition-init.ly (right):
> > > >
> > > > http://codereview.appspot.com/224082/diff/1/3#newcode51
> > > > ly/chord-repetition-init.ly:51: #(define-public (tab-repeat-chord
> > > > previous-chord location duration articulations)
> > > > It would be  better to define a generic repetition function, taking 
> > > > the
> > > > event types that should be kept for NoteEvents. 
> > > > default-repeat-chord and
> > > > tab-repeat-chord would then use this function.  I'm writing it on 
> > > > other
> > > > post.
> > > >       
> > > Done. Thanks for this improvement!
> > >
> > > Marc
> > >
> > > http://codereview.appspot.com/224082/show
> > >     
> >
> > Shouldn't there be a few words of explantion about using q and
> > \tabChordRepetition somewhere in 2.4.1 "Common notation for fretted
> > strings"?
> >   
> I'll have a look at it.
At the beginning of Documentation/notation/fretted-instruments.itely, it 
says:

@warning{String numbers @strong{must} be defined inside a chord
construct even if there is only a single note.}

But something like c4\4 works pretty well, and IIUC, the comments
in lily/tab-note-heads-engraver.cc verify that string numbers are
allowed within and outside chord constructs. So, while adding
some remarks about  \tabChordRepetition, should I delete the @warning{...} ?

Marc