Re: [PATCH] Issue 1046

[Carl Sorensen]

On 3/31/10 3:17 AM, "Marc Hohl" <address@hidden> wrote:

> Graham Percival schrieb:
>> On Wed, Mar 31, 2010 at 12:01 AM, Marc Hohl <address@hidden> wrote:
>>  
>>> diff --git a/Documentation/notation/fretted-strings.itely
>>> @@ -1470,13 +1470,33 @@ text markup.
>>> address@hidden,ragged-right,verbatim]
>>> +music = \relative c' {
>>> +  < a\3 \deadNote c\2 a'\1 >4
>>> +  < b\3 \deadNote d\2 b'\1 >4
>>> +  < c\3 \deadNote e\2 c'\1 >8
>>> +  \deadNotesOn \times 2/3 { g16\3 b\2 e\1 } \deadNotesOff
>>>    
>> 
>> Predefined commands should go on their own lines unless they refer to
>> a single note.  \deadNote is fine, but \deadNoteOn/Off should be on
>> separate lines.
>> 
>>  
> Ok, done.
>>> +\new StaffGroup <<
>>> +  \new Staff {
>>> +    \clef "treble_8"
>>> +    \override Voice.StringNumber #'transparent = ##t
>>>    
>> 
>> Is this absolutely vital to demonstrate \deadNote ?  (honest question:
>> if yes, fine, but please add a comment saying that it's necessary.  If
>> it's not necessary, then please remove the tweak)
>>  
> To be honest: it isn't strictly necessary, but the
> displayed string numbers are partly crossed out by the
> beams; furthermore, string numbers in combination with
> tablature is redundant. But for sake of simplicity, I removed
> the tweak.

Why not just remove the string numbers?  Or eliminate the beams by changing
the rhythms?

Carl