lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fill-line spec and (center-/right-)column alignment [was: PATCH: iss


From: Alexander Kobel
Subject: Re: fill-line spec and (center-/right-)column alignment [was: PATCH: issue 1116 (fill-line regression 2.13.11 to 2.13.12+)]
Date: Tue, 15 Jun 2010 01:41:52 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100423 Lightning/1.0b1 Thunderbird/3.0.4

On 2010-06-15 00:28, Alexander Kobel wrote:
On 14 June 2010 21:47, Alexander Kobel<address@hidden> wrote:
On the other hand, I don't quite get why word-space = 1 is necessary. [...]

Anybody knows if we can remove the minimum space? IMHO, this will make
the code cleaner without causing unexpected trouble on the user side.
Checking the NR A.8.2, \fill-line is the only markup command to mention
a separate default for word-space, and the description of \fill-line
says nothing about it's meaning. Looks to me like it was copied from
\line, and been forgotten afterwards.

I updated the issue on Rietveld with a version of fill-line where word-space is completely ignored: <http://codereview.appspot.com/1689041>.

I think I know now how to properly compile and check the regression tests, and I can't spot anything that's broken by this change. Comments?


Cheers,
Alexander



reply via email to

[Prev in Thread] Current Thread [Next in Thread]