Re: Experimental support for woff fonts in svg. (issue1428042)

[pnorcks]

Just a few more comments...


http://codereview.appspot.com/1428042/diff/34001/35014
File scm/output-svg.scm (right):

http://codereview.appspot.com/1428042/diff/34001/35014#newcode25
scm/output-svg.scm:25: ;;; set by framework-gnome.scm
;;; set by framework-svg.scm

http://codereview.appspot.com/1428042/diff/34001/35014#newcode302
scm/output-svg.scm:302: (comment "FIXME: how to select glyph by name,
altglyph is broken?"))
I think the altglyph element is used for different purposes than what
you are trying for here.

I also think we should stay away from SVG features that didn't make it
into SVG Tiny 1.2.  altglyph is one of those features.

See my comment below for a possibility.

http://codereview.appspot.com/1428042/diff/34001/35014#newcode307
scm/output-svg.scm:307: (set! alist (assoc-set! alist attr val)))
Maybe we could add a "class" attribute that provides descriptive
information?

(set-attribute 'class expr)

I'm considering adding this to the default SVG output, but I need to
refactor a bit first.

http://codereview.appspot.com/1428042/show