Re: 100+ warnings and some cosmetics along the way (issue1724041)

[Peter Chubb]

>>>>> "Han-Wen" == Han-Wen Nienhuys <address@hidden> writes:

Han-Wen> On Thu, Jun 17, 2010 at 9:55 AM, Pap Lôrinc
Han-Wen> <address@hidden> wrote:

Han-Wen> Regarding 'long long', flower/include/flower-proto.hh says

Han-Wen>   typedef long long I64;

Han-Wen> but this is wrong, as it is not conditional on the
Han-Wen> architecture (this code is from way before 64 bit PCs), and
Han-Wen> fixes would be welcome.

Han-Wen> For rationals (the only place we use I64), long long
Han-Wen> (ie. 128bit numbers) would be welcome to prevent overflow.

long long is 64 bit even on most 64-bit machines 

The C standard just says it has to be at least as long as long.

i.e, 1 == sizeof (char) < sizeof (short) <= sizeof(int) <= sizeof
                        (long) <= sizeof (long long)

and sizeof (short) >= 2


--
Dr Peter Chubb                                  peter DOT chubb AT nicta.com.au
http://www.ertos.nicta.com.au               ERTOS within National ICT Australia
All things shall perish from under the sky/Music alone shall live, never to die