Re: Add \path markup command, and use it for \eyeglasses. (issue1730044)

[pnorcks]

Reviewers: carl.d.sorensen_gmail.com,

Message:
Thanks Carl.

I'll be uploading a new patch shortly.

-Patrick


http://codereview.appspot.com/1730044/diff/1/2
File scm/define-markup-commands.scm (right):

http://codereview.appspot.com/1730044/diff/1/2#newcode622
scm/define-markup-commands.scm:622: (number? number? number? boolean?
string?)
On 2010/06/20 11:07:37, Carl wrote:
> Can (and/or should) cap, join, and fill become part of a path-details
property?

> It's convenient when creating a new markup type to put all the
arguments needed
> into an argument list.  But it's more consistent with LilyPond syntax
to have
> all the things that affect appearance be properties that can have
default values
> set (and documented) in the code.

Thank you for the suggestion.  I have decided to change these into
separate properties.  Let me know what you think.

http://codereview.appspot.com/1730044/diff/1/2#newcode668
scm/define-markup-commands.scm:668: \"
On 2010/06/20 11:07:37, Carl wrote:
> I think this inline snippet is fine.  What characteristics of the
snippet need
> to be "better" in your opinion?

I thought it would be nice to have a snippet that is more "musical", but
I suppose it doesn't matter at this point.

http://codereview.appspot.com/1730044/diff/1/2#newcode684
scm/define-markup-commands.scm:684: (cons 0 0)))
On 2010/06/20 11:07:37, Carl wrote:
> Is it possible to have the path command estimate reasonable extents,
rather
> than using (0 . 0) and (0 . 0)?  Since we know the thickness of the
line, and
> we have a list of points, it seems we should be able to keep track of
the
> maximum and minimum X and Y coordinates during the path creation.

This should be possible, but I'm not sure how to implement it,
especially when relative coordinates are involved.

Description:
Add \path markup command, and use it for \eyeglasses.

* Modified 'path routines to accept optional arguments that allow for
  customizing line-cap styles, line-join styles, and whether the path
  should be filled or not.

* Add \path markup command that uses all of these optional parameters.

* Redo the implementation of \eyeglasses using this new \path command.
  This allows for using \eyeglasses in the SVG output.

TODO/questions:

* Are the arguments for \path in a sane order?

* Should some of the arguments have default values, not requiring user
  input unless they want to override them (e.g. line-join and line-cap)?

* The documentation of the command can probably be condensed and/or
  reformatted.

* Consider adding support for variable path thickness (to \eyeglasses).

* Need a better inline snippet for demonstrating \path

Please review this at http://codereview.appspot.com/1730044/show

Affected files:
  M scm/define-markup-commands.scm
  M scm/output-ps.scm
  M scm/output-svg.scm