|
From: | Carl . D . Sorensen |
Subject: | Re: Add \path markup command, and use it for \eyeglasses. (issue1730044) |
Date: | Sat, 26 Jun 2010 13:35:59 +0000 |
LGTM, with a couple of minor spacing issues. Carl http://codereview.appspot.com/1730044/diff/17001/12002 File scm/define-markup-commands.scm (right): http://codereview.appspot.com/1730044/diff/17001/12002#newcode2782 scm/define-markup-commands.scm:2782: (make-override-markup '(line-cap-style . butt) indentation -- (make-override-markup is indented too far. http://codereview.appspot.com/1730044/diff/17001/12003 File scm/output-ps.scm (right): http://codereview.appspot.com/1730044/diff/17001/12003#newcode279 scm/output-ps.scm:279: (ly:warning (_ "unknown line-cap-style: ~S") Apparently there's a whitespace error on this line, as it wraps with nothing visible on the wrapped part. http://codereview.appspot.com/1730044/show
[Prev in Thread] | Current Thread | [Next in Thread] |