Re: Add \path markup command, and use it for \eyeglasses. (issue1730044)

[pnorcks]

I am currently working on integrating my work with Mike's new stencil
routines, so I'll post a new patch when that's ready.

Jan: I like your idea about using a separate module to evaluate the
various commands, though IIUC, this would be duplicating the work done
by the backend "path" procedures in output-ps.scm and output-svg.scm,
since they already take a list of commands and convert them to either
PostScript or SVG paths.

Thanks,
Patrick


http://codereview.appspot.com/1730044/diff/17001/12002
File scm/define-markup-commands.scm (right):

http://codereview.appspot.com/1730044/diff/17001/12002#newcode2782
scm/define-markup-commands.scm:2782: (make-override-markup
'(line-cap-style . butt)
On 2010/06/26 13:35:59, Carl wrote:
> indentation -- (make-override-markup is indented too far.

Fixed, thanks.

http://codereview.appspot.com/1730044/diff/17001/12003
File scm/output-ps.scm (right):

http://codereview.appspot.com/1730044/diff/17001/12003#newcode279
scm/output-ps.scm:279: (ly:warning (_ "unknown line-cap-style: ~S")
On 2010/06/26 13:35:59, Carl wrote:
> Apparently there's a whitespace error on this line, as it wraps with
nothing
> visible on the wrapped part.

This is an artifact of the way Rietveld chose to display the diff.

If you look at the line numbers, you'll see that everything lines up
fine.

http://codereview.appspot.com/1730044/show