Re: Add \path markup command, and use it for \eyeglasses. (issue1730044)

[pnorcks]

Thanks Carl.  I'll upload my changes shortly.

-Patrick


http://codereview.appspot.com/1730044/diff/35001/36003
File scm/define-stencil-commands.scm (left):

http://codereview.appspot.com/1730044/diff/35001/36003#oldcode30
scm/define-stencil-commands.scm:30: connected-shape
On 2010/07/28 19:08:16, Carl wrote:
> Shouldn't path be in this list to replace connected-shape?

path is already in the list; see line 43.

http://codereview.appspot.com/1730044/diff/35001/36007
File scm/stencil.scm (right):

http://codereview.appspot.com/1730044/diff/35001/36007#newcode294
scm/stencil.scm:294: (define-public (path-min-max origin pointlist)
On 2010/07/28 19:08:16, Carl wrote:
> Does this need define-public, instead of define?

> Does it need to be called from a .ly file?

No, this one is for internal use.  I'll remove the "-public".

http://codereview.appspot.com/1730044/diff/35001/36007#newcode359
scm/stencil.scm:359: (define-public (make-connected-path-stencil
pointlist thickness
On 2010/07/28 19:08:16, Carl wrote:
> If it's define-public, it needs a doc string.  Does it need to be
define-public?

I think this one should be exported, since it is just as useful as the
other stencil routines in this file, even though it's a bit limited.

I'll add a doc string.

http://codereview.appspot.com/1730044/show