[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Add \path markup command, and use it for \eyeglasses. (issue1730044
From: |
Carl . D . Sorensen |
Subject: |
Re: Add \path markup command, and use it for \eyeglasses. (issue1730044) |
Date: |
Wed, 28 Jul 2010 19:08:16 +0000 |
Looks very nice! Just a few comments.
Thanks,
Carl
http://codereview.appspot.com/1730044/diff/35001/36003
File scm/define-stencil-commands.scm (left):
http://codereview.appspot.com/1730044/diff/35001/36003#oldcode30
scm/define-stencil-commands.scm:30: connected-shape
Shouldn't path be in this list to replace connected-shape?
http://codereview.appspot.com/1730044/diff/35001/36007
File scm/stencil.scm (right):
http://codereview.appspot.com/1730044/diff/35001/36007#newcode294
scm/stencil.scm:294: (define-public (path-min-max origin pointlist)
Does this need define-public, instead of define?
Does it need to be called from a .ly file?
http://codereview.appspot.com/1730044/diff/35001/36007#newcode359
scm/stencil.scm:359: (define-public (make-connected-path-stencil
pointlist thickness
If it's define-public, it needs a doc string. Does it need to be
define-public?
http://codereview.appspot.com/1730044/show
- Re: Add \path markup command, and use it for \eyeglasses. (issue1730044), mtsolo, 2010/07/05
- Re: Add \path markup command, and use it for \eyeglasses. (issue1730044), Carl . D . Sorensen, 2010/07/05
- Re: Add \path markup command, and use it for \eyeglasses. (issue1730044), pnorcks, 2010/07/13
- Re: Add \path markup command, and use it for \eyeglasses. (issue1730044), pnorcks, 2010/07/28
- Re: Add \path markup command, and use it for \eyeglasses. (issue1730044),
Carl . D . Sorensen <=
- Re: Add \path markup command, and use it for \eyeglasses. (issue1730044), pnorcks, 2010/07/28