[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Change syntax for woodwind-diagram markup (issue1946043)
From: |
n . puttock |
Subject: |
Re: Change syntax for woodwind-diagram markup (issue1946043) |
Date: |
Sat, 14 Aug 2010 19:47:59 +0000 |
http://codereview.appspot.com/1946043/diff/1/5
File scm/define-grob-properties.scm (right):
http://codereview.appspot.com/1946043/diff/1/5#newcode414
scm/define-grob-properties.scm:414: (graphical ,boolean? "Display in
graphical, rather than textual, form.")
don't need this
http://codereview.appspot.com/1946043/diff/1/6
File scm/display-woodwind-diagrams.scm (right):
http://codereview.appspot.com/1946043/diff/1/6#newcode1870
scm/display-woodwind-diagrams.scm:1870: (thickness .1)
0.1
http://codereview.appspot.com/1946043/diff/1/6#newcode1952
scm/display-woodwind-diagrams.scm:1952: (let* ((radius (chain-assoc-get
'size props 1.0))
Since these are bound with defaults above, you don't need to use
chain-assoc-get
(radius size)
or use the properties directly instead of rebinding
http://codereview.appspot.com/1946043/diff/1/6#newcode1954
scm/display-woodwind-diagrams.scm:1954: (display-graphic
(chain-assoc-get 'graphic props #t))
graphical
http://codereview.appspot.com/1946043/diff/1/6#newcode1966
scm/display-woodwind-diagrams.scm:1966: ;(user-draw-commands (cadddr
input-list))
remove
http://codereview.appspot.com/1946043/show