[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: T1249 - Remove (define define-ly-syntax define-public). (issue231304
From: |
pnorcks |
Subject: |
Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044) |
Date: |
Thu, 04 Nov 2010 17:49:33 +0000 |
Hi Ian,
I found a rebasing issue that should be sorted out, as explained in my
comment below.
Also, I think the subject line of this patch can be improved, since
we're no longer removing `define-ly-syntax', just revising it.
Thanks,
Patrick
http://codereview.appspot.com/2313044/diff/7001/scm/ly-syntax-constructors.scm
File scm/ly-syntax-constructors.scm (right):
http://codereview.appspot.com/2313044/diff/7001/scm/ly-syntax-constructors.scm#newcode251
scm/ly-syntax-constructors.scm:251: (define-ly-syntax-simple (partial
dur)
This part of the patch reverts Neil's changes as part of the fix for
#372.
Run the following command to see what I mean:
git log -p scm/ly-syntax-constructors.scm
In other words, there should be no changes to this procedure at all for
your patch.
http://codereview.appspot.com/2313044/
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), ianhulin44, 2010/11/04
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044),
pnorcks <=
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), ianhulin44, 2010/11/04
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), v . villenave, 2010/11/04
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), ianhulin44, 2010/11/04
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), pnorcks, 2010/11/04
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), ianhulin44, 2010/11/05
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), pnorcks, 2010/11/10