[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: T1249 - Remove (define define-ly-syntax define-public). (issue231304
From: |
pnorcks |
Subject: |
Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044) |
Date: |
Thu, 04 Nov 2010 23:50:25 +0000 |
Hi Ian,
Just about there... Three lines with whitespace issues, and then
everything should be ready to go.
Thanks,
Patrick
http://codereview.appspot.com/2313044/diff/20001/scm/ly-syntax-constructors.scm
File scm/ly-syntax-constructors.scm (right):
http://codereview.appspot.com/2313044/diff/20001/scm/ly-syntax-constructors.scm#newcode38
scm/ly-syntax-constructors.scm:38: 'parser
`git apply' complains about a space before the tabs on this line.
http://codereview.appspot.com/2313044/diff/20001/scm/ly-syntax-constructors.scm#newcode40
scm/ly-syntax-constructors.scm:40: (cdr args))
For consistency, these two lines should use tabs, just like they are at
present (in git).
http://codereview.appspot.com/2313044/
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), ianhulin44, 2010/11/04
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), pnorcks, 2010/11/04
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), ianhulin44, 2010/11/04
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), v . villenave, 2010/11/04
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), ianhulin44, 2010/11/04
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044),
pnorcks <=
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), ianhulin44, 2010/11/05
- Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044), pnorcks, 2010/11/10