Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044)

[ianhulin44]

http://codereview.appspot.com/2313044/diff/15001/scm/ly-syntax-constructors.scm
File scm/ly-syntax-constructors.scm (right):

http://codereview.appspot.com/2313044/diff/15001/scm/ly-syntax-constructors.scm#newcode20
scm/ly-syntax-constructors.scm:20: (defmacro define-ly-syntax (args .
body)
On 2010/11/04 21:21:09, Valentin Villenave wrote:
> Is there a way to document defmacros with docstrings instead of
comments?

I don't know.  The code as is fixes the crash when compiling this stuff
using Guile V1.9 and that's the aim of the patch.
I suspect the whole file could be re-written using (define-syntax) and
(syntax-rules), but I don't have enough scheme-fu and thinking about it
made my head hurt.
Ian

http://codereview.appspot.com/2313044/diff/15001/scm/ly-syntax-constructors.scm#newcode39
scm/ly-syntax-constructors.scm:39: 'location
On 2010/11/04 21:21:09, Valentin Villenave wrote:
> Are you using Emacs-like indentation? "tabs for indentation, spaces
for
> alignment"; it seems that the rest of the file is indented that way.
By the way
> isn't there a space char missing here?

Done.

http://codereview.appspot.com/2313044/