[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch] Add support for tempo ranges (issue3248042)
From: |
v . villenave |
Subject: |
Re: [Patch] Add support for tempo ranges (issue3248042) |
Date: |
Thu, 25 Nov 2010 23:10:49 +0000 |
On 2010/11/22 18:51:55, Reinhold wrote:
Why do you define two different variables count-markup and
range-markup here,
one of which is always #f?
I would simply create one count-markup, defined as (if (pair?
count-or-range)
(create markup for range) (create markup for count)).
Then you don't need the (if count-markup...) here, either.
Sorry Reinhold, I misunderstood your count-markup comment (I thought you
were referring to metronome-engraver.cc). You're right, it makes up for
a much nicer code.
New patch set, that addresses Carl's and Neil's comments as well. Thanks
guys, you've been really helpful!
Cheers,
Valentin.
http://codereview.appspot.com/3248042/
- Re: [Patch] Add support for tempo ranges (issue3248042), (continued)
- Re: [Patch] Add support for tempo ranges (issue3248042), reinhold . kainhofer, 2010/11/22
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/22
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/23
- Re: [Patch] Add support for tempo ranges (issue3248042), Carl . D . Sorensen, 2010/11/23
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/24
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), Carl . D . Sorensen, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042),
v . villenave <=
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/26
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/26
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/26
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/30