[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch] Add support for tempo ranges (issue3248042)
From: |
Carl . D . Sorensen |
Subject: |
Re: [Patch] Add support for tempo ranges (issue3248042) |
Date: |
Thu, 25 Nov 2010 15:24:34 +0000 |
On 2010/11/25 11:42:40, Valentin Villenave wrote:
On 2010/11/25 00:10:01, Neil Puttock wrote:
> That sounds OK to me.
In scm/translation-functions.scm, I'd prefer to see the argument called
"count", not "count-or-range". The property is timeUnitCount, IIUC.
The count can either be a number or a range, but it's still a count.
But I won't hold up approval of the patch for this; it's just an
opinion.
Thanks,
Carl
http://codereview.appspot.com/3248042/
- [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/22
- Re: [Patch] Add support for tempo ranges (issue3248042), Carl . D . Sorensen, 2010/11/22
- Re: [Patch] Add support for tempo ranges (issue3248042), reinhold . kainhofer, 2010/11/22
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/22
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/23
- Re: [Patch] Add support for tempo ranges (issue3248042), Carl . D . Sorensen, 2010/11/23
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/24
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042),
Carl . D . Sorensen <=
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/26
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/26
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/26
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/30