Re: [Patch] Add support for tempo ranges (issue3248042)

[n . puttock]

On 2010/11/25 23:10:49, Valentin Villenave wrote:
> On 2010/11/22 18:51:55, Reinhold wrote:
> > Why do you define two different variables count-markup and
range-markup here,
> > one of which is always #f?
> > I would simply create one count-markup, defined as (if (pair?
count-or-range)
> > (create markup for range) (create markup for count)).
> > Then you don't need the (if count-markup...) here, either.

> Sorry Reinhold, I misunderstood your count-markup comment (I thought
you were
> referring to metronome-engraver.cc). You're right, it makes up for a
much nicer
> code.

Where is this nicer code?  :)

Almost forgot: you need to tweak the display method for \tempo so

\tempo 4 = 60 ~ 63

doesn't look like this:

\tempo 4 = (60 . 63)

Cheers,
Neil

http://codereview.appspot.com/3248042/