Re: Fix #1205. (issue2145047)

[v . villenave]

On 2010/09/12 21:42:50, Neil Puttock wrote:
> This patch changes the internal representation of \tempo so it uses an
event to
> trigger creation of a metronome mark.

Wow, I can understand why my patch would wreak havoc through your work!
I only had a quick look, but it certainly does look elegant. If you
don't mind my asking, what makes it better to have a tempo-change event
rather than just waiting for some properties to change?

There were some undocumented "features" of Reinhold's implementation
that your code might not break compatibility with (for example, manually
setting Score.tempoUnitCount would reprint the tempoText, etc.).

It's unfortunate that whilst you were trying to make less things
hardcoded in parser.yy, I've been doing the exact opposite... :-)

Cheers,
Valentin.

http://codereview.appspot.com/2145047/