Re: Modify fret calculation algorithm (issue3320041)

[Patrick Schmidt]

Am 26.11.2010 um 23:41 schrieb address@hidden:

> On 2010/11/26 19:39:06, steve.yegge wrote:
> > Hi Carl,
>
> > I looked through the code; it looks great.  I built it and tested it
> fairly
> > thoroughly, and found no problems with it -- both features work as
> advertised.
>
> Thanks for the testing!
>
>
> > I tried defaultStrings with single-string melodies, thirds, octaves,
> skip-string
> > chords and several other configurations.  I didn't find any bugs.  In
> one case I
> > did get a rather cryptic error message because I'd inadvertently
> specified the
> > strings in reverse order -- but some reason I've been unable to
> reproduce that
> > error message.
>
> Yes, the assumption is that the string specification needs to be in  
> the
> same order as the note specification.  When the documentation is done,
> we'll need to be sure that is mentioned.  If you specify the notes and
> the strings in reverse order, it's likely to be impossible to find  
> frets
> that are close enough together to meet both notes.
>
>
> > I also tried out the zero-fingering feature.  It works quite well in
> conjunction
> > with setting the minimumFret.  Again, I found no bugs, although my
> testing
> > shouldn't be considered exhaustive.
>
> I think it should work, and we haven't found any bugs yet, so once we
> get a style review we should be able to go ahead and push.  If bugs  
> show
> up later, we'll fix them.
>
>
> > These features will do wonders for cutting down the verbosity in my
> music files.
> >   Thanks for implementing this!
>
> You're welcome.  Thanks to all who contributed ideas.
>
> Now for the big request -- since I've made things easier for your  
> music
> files, would you be willing to write documentation for these two
> features?  It should go in the Default Tablatures subsection of  
> Notation
> Reference 2.4.1 Common Notation for Fretted Strings.  The source  
> resides
> in Documentation/notation/fretted-strings.itely.
I'll do it as soon as possible. But first of all I need to reinstall  
lilybuntu on my mac ox 10.4 and test your patch. At the moment I  
can't build LilyPond...

Thanks,

patrick
> The policies for working on documentation are found in chapter 4 of  
> the
> Contributors' Guide.
>
> Thanks,
>
> Carl
>
>
>
>
> http://codereview.appspot.com/3320041/