Re: Modify fret calculation algorithm (issue3320041)

[n . puttock]

http://codereview.appspot.com/3320041/diff/4001/input/regression/tablature-default-strings.ly
File input/regression/tablature-default-strings.ly (right):

http://codereview.appspot.com/3320041/diff/4001/input/regression/tablature-default-strings.ly#newcode4
input/regression/tablature-default-strings.ly:4: texidoc="
texidoc = "

http://codereview.appspot.com/3320041/diff/4001/input/regression/tablature-default-strings.ly#newcode5
input/regression/tablature-default-strings.ly:5: Context property
defaultStrings defines desired strings
@code{defaultStrings}

http://codereview.appspot.com/3320041/diff/4001/input/regression/tablature-zero-finger.ly
File input/regression/tablature-zero-finger.ly (right):

http://codereview.appspot.com/3320041/diff/4001/input/regression/tablature-zero-finger.ly#newcode4
input/regression/tablature-zero-finger.ly:4: texidoc="
texidoc = "

http://codereview.appspot.com/3320041/diff/4001/input/regression/tablature-zero-finger.ly#newcode11
input/regression/tablature-zero-finger.ly:11: <d-0 a'-2 d-3 f-1>1
I can't see any difference in output with or without the zero.

An invalid zero fingering causes a crash:

\new TabVoice \relative c' {
  <f-0>
}

http://codereview.appspot.com/3320041/diff/4001/scm/translation-functions.scm
File scm/translation-functions.scm (right):

http://codereview.appspot.com/3320041/diff/4001/scm/translation-functions.scm#newcode292
scm/translation-functions.scm:292: (strings-used (if (and (zero?
(entry-count defined-strings))
(zero? (

http://codereview.appspot.com/3320041/diff/4001/scm/translation-functions.scm#newcode361
scm/translation-functions.scm:361: (define (finger-number event)
unused

http://codereview.appspot.com/3320041/diff/4001/scm/translation-functions.scm#newcode413
scm/translation-functions.scm:413: (begin
redundant begin

http://codereview.appspot.com/3320041/diff/4001/scm/translation-functions.scm#newcode417
scm/translation-functions.scm:417: ))
move to previous line

http://codereview.appspot.com/3320041/