Re: Modify fret calculation algorithm (issue3320041)

[David Kastrup]

address@hidden writes:

> Yes, the assumption is that the string specification needs to be in
> the same order as the note specification.  When the documentation is
> done, we'll need to be sure that is mentioned.  If you specify the
> notes and the strings in reverse order, it's likely to be impossible
> to find frets that are close enough together to meet both notes.

Sorry to disagree, but I see two sane approaches here.

a) when the specification is not in the required order, throw an error.
b) when the specification is not in the required order, sort it.

The preference being b).  If the problem is that this would require a
check of some data structure every time before using it, make an
interface for creating the data structure and discourage the user from
ever creating this data structure (subject to change without notice)
without using the given constructing function.

The insane approach is

c) produce unfathomable results for things that seem likely to work, and
   document somewhere that this will not work.

There is no sense in tripping people up and document how it was done.
It inflates the documentation with information beyond user level and
thus keeps users from reading it since it does not much except make
their eyes glaze over.

This rant was brought to you discourtesy of

-- 
David Kastrup