Re: Modify fret calculation algorithm (issue3320041)

[Carl . D . Sorensen]

I've responded to all of Neil's comments.

Thanks for the review, Neil!

Carl



http://codereview.appspot.com/3320041/diff/4001/input/regression/tablature-default-strings.ly
File input/regression/tablature-default-strings.ly (right):

http://codereview.appspot.com/3320041/diff/4001/input/regression/tablature-default-strings.ly#newcode4
input/regression/tablature-default-strings.ly:4: texidoc="
On 2010/11/27 00:39:21, Neil Puttock wrote:
> texidoc = "

Done.

http://codereview.appspot.com/3320041/diff/4001/input/regression/tablature-default-strings.ly#newcode5
input/regression/tablature-default-strings.ly:5: Context property
defaultStrings defines desired strings
On 2010/11/27 00:39:21, Neil Puttock wrote:
> @code{defaultStrings}

Done.

http://codereview.appspot.com/3320041/diff/4001/input/regression/tablature-zero-finger.ly
File input/regression/tablature-zero-finger.ly (right):

http://codereview.appspot.com/3320041/diff/4001/input/regression/tablature-zero-finger.ly#newcode4
input/regression/tablature-zero-finger.ly:4: texidoc="
On 2010/11/27 00:39:21, Neil Puttock wrote:
> texidoc = "

Done.

http://codereview.appspot.com/3320041/diff/4001/input/regression/tablature-zero-finger.ly#newcode11
input/regression/tablature-zero-finger.ly:11: <d-0 a'-2 d-3 f-1>1
On 2010/11/27 00:39:21, Neil Puttock wrote:
> I can't see any difference in output with or without the zero.

I've changed this to a chord that will put the D on the 5th string
without the zero, but on the 4th string with the zero.

> An invalid zero fingering causes a crash:

> \new TabVoice \relative c' {
>    <f-0>

This has been fixed to issue a warning and fit the note to some other
string.  Another alternative is to issue a warning and leave the note
out of the tablature.

I've got a question out as to which behavior is preferable.

I've also added a regtest for this behavior.

http://codereview.appspot.com/3320041/diff/4001/scm/translation-functions.scm
File scm/translation-functions.scm (right):

http://codereview.appspot.com/3320041/diff/4001/scm/translation-functions.scm#newcode292
scm/translation-functions.scm:292: (strings-used (if (and (zero?
(entry-count defined-strings))
On 2010/11/27 00:39:21, Neil Puttock wrote:
> (zero? (

Done.

http://codereview.appspot.com/3320041/