[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Doc: CG: clarify lily-git.tcl and git-cl. (issue3396042)
From: |
v . villenave |
Subject: |
Re: Doc: CG: clarify lily-git.tcl and git-cl. (issue3396042) |
Date: |
Mon, 06 Dec 2010 23:12:09 +0000 |
Hi Graham,
LGTM as well. Just a few comments:
http://codereview.appspot.com/3396042/diff/1/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):
http://codereview.appspot.com/3396042/diff/1/Documentation/contributor/source-code.itexi#newcode143
Documentation/contributor/source-code.itexi:143: @quotation
Is there a rule for the use of @quotation? (I noticed there's another
one in source-code.itexi.) If so, we probably should add it to the CG's
Syntax Survey.
http://codereview.appspot.com/3396042/diff/1/Documentation/contributor/source-code.itexi#newcode193
Documentation/contributor/source-code.itexi:193: be less than 64KB) to
@email{frogs@@lilynet.net}.
I wouldn't bother with the size limit, it's much less drastic on address@hidden
What I *would* mention, however, is to add [PATCH] in the email's
subject.
http://codereview.appspot.com/3396042/diff/1/Documentation/contributor/source-code.itexi#newcode1032
Documentation/contributor/source-code.itexi:1032: You must have a gmail
account.
Are all Google accounts Gmail accounts? (I don't suppose it's owrth
adding a @uref{https://www.google.com/accounts/NewAccount} link, is it?)
http://codereview.appspot.com/3396042/diff/1/Documentation/contributor/source-code.itexi#newcode1051
Documentation/contributor/source-code.itexi:1051: answer with a newline
(CR).
How about "just hit Return"?
http://codereview.appspot.com/3396042/