On 11-03-29 08:24 PM, address@hidden wrote:
On Mar 29, 2011, at 10:12 PM, Colin Campbell wrote:
On 11-03-29 04:54 PM, address@hidden
wrote:
On Mar 28, 2011, at 6:39 PM, address@hidden
wrote:
Looks much more readable, thanks!
http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc
File
lily/beam-collision-engraver.cc (right):
http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc#newcode59
lily/beam-collision-engraver.cc:59:
// Start conisdering grobs at the
first grob whose end falls at or
after the beam's beginning.
typo: conisdering
http://codereview.appspot.com/4290069/
Can somebody please test this patch
out on a few thorny keyboard pieces before I push it? It
will make beam collision kick in on all beams, and I want
to make sure that I don't run into the same issue I did w/
accidentals. I would do it myself, but I am not in
possession of anything that could really test this to the
max.
Cheers,
MS
If you point me toward a few thorny keyboard pieces, I can
run some tests for you, Mike.
Colin
Thanks Colin!
I don't have any, but I'm assuming that some of these would
suffice:
Cheers,
MS
I applied your patchy to a just-now git, ran make and make check
cleanly, no unexpected regressions, so I used Frescobaldi to force
the lilypond version to 2.13.57 and compiled the Scriabin Opus 11 nr
1. I didn't see any glaring problems, although all those beams
broken across staves freaked me only a little more than the
quintuplets beamed across bar lines!
Hope that helps, Mike.
Colin
--
The test of our progress is not whether we add more to the abundance
of those who have much, it is whether we provide enough for those who
have too little.
-Franklin D. Roosevelt, 32nd US President (1882-1945)
|