[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Adds beam collision avoidance to auto beaming (issue4290069)
From: |
n . puttock |
Subject: |
Re: Adds beam collision avoidance to auto beaming (issue4290069) |
Date: |
Mon, 28 Mar 2011 20:50:09 +0000 |
http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc
File lily/beam-collision-engraver.cc (right):
http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc#newcode50
lily/beam-collision-engraver.cc:50: sort (covered_grobs_.begin (),
covered_grobs_.end (), Grob::less);
vector_sort (covered_grobs_, Grob::less);
http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc#newcode51
lily/beam-collision-engraver.cc:51: sort (beams_.begin (), beams_.end
(), Grob::less);
vector_sort (beams_, Grob::less);
http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc#newcode54
lily/beam-collision-engraver.cc:54: if (!covered_grobs_.size ())
You probably want this at the top.
http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc#newcode59
lily/beam-collision-engraver.cc:59: // Start conisdering grobs at the
first grob whose end falls at or after the beams beginning.
considering
beam's
http://codereview.appspot.com/4290069/diff/8001/lily/beam-collision-engraver.cc#newcode66
lily/beam-collision-engraver.cc:66: Only consider grobs whose end falls
at or after the beams beginning.
beam's
http://codereview.appspot.com/4290069/
- Adds beam collision avoidance to auto beaming (issue4290069), mtsolo, 2011/03/26
- Re: Adds beam collision avoidance to auto beaming (issue4290069), percival . music . ca, 2011/03/27
- Re: Adds beam collision avoidance to auto beaming (issue4290069), hanwenn, 2011/03/28
- Re: Adds beam collision avoidance to auto beaming (issue4290069), mtsolo, 2011/03/28
- Re: Adds beam collision avoidance to auto beaming (issue4290069),
n . puttock <=
- Re: Adds beam collision avoidance to auto beaming (issue4290069), mtsolo, 2011/03/28
- Re: Adds beam collision avoidance to auto beaming (issue4290069), percival . music . ca, 2011/03/28
- Re: Adds beam collision avoidance to auto beaming (issue4290069), address@hidden, 2011/03/29
Re: Adds beam collision avoidance to auto beaming (issue4290069), hanwenn, 2011/03/30