Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060)

[hanwenn]

http://codereview.appspot.com/4898060/diff/1/lily/ledger-line-spanner.cc
File lily/ledger-line-spanner.cc (right):

http://codereview.appspot.com/4898060/diff/1/lily/ledger-line-spanner.cc#newcode89
lily/ledger-line-spanner.cc:89: continue;
can't you check poss.find(max(0, lincount - *it)) ?

I don't understand what this is supposed to do ; in which cases do you
want to skip ledger creation?

http://codereview.appspot.com/4898060/diff/1/lily/ledger-line-spanner.cc#newcode337
lily/ledger-line-spanner.cc:337: poss[(Direction) sign (pos)].insert
(sign (pos) * int (rint (pos - staff_extent[Direction (sign (pos))])) /
2);
have you tried if you can change sign() to return a Direction ?

http://codereview.appspot.com/4898060/