Re: Creates a Flag grob. (issue 4922042)

[n . puttock]

http://codereview.appspot.com/4922042/diff/17001/lily/flag.cc
File lily/flag.cc (right):

http://codereview.appspot.com/4922042/diff/17001/lily/flag.cc#newcode147
lily/flag.cc:147: "what style of flag glyph is typeset on a"
" what

http://codereview.appspot.com/4922042/diff/17001/lily/flag.cc#newcode148
lily/flag.cc:148: "@code{Stem}.  Valid options include @code{'()}"
" @code{Stem}.

http://codereview.appspot.com/4922042/diff/17001/lily/flag.cc#newcode149
lily/flag.cc:149: "for standard flags, @code{'mensural} and"
" for

http://codereview.appspot.com/4922042/diff/17001/lily/flag.cc#newcode150
lily/flag.cc:150: "@code{'no-flag}, which switches off the flag.",
" @code{'no-flag}

http://codereview.appspot.com/4922042/diff/17001/lily/flag.cc#newcode154
lily/flag.cc:154: "stem "
unused

http://codereview.appspot.com/4922042/diff/17001/lily/stem-engraver.cc
File lily/stem-engraver.cc (right):

http://codereview.appspot.com/4922042/diff/17001/lily/stem-engraver.cc#newcode191
lily/stem-engraver.cc:191: if (scm_is_string (get_property
("whichBar")))
doc whichBar as read property

http://codereview.appspot.com/4922042/diff/17001/lily/stem.cc
File lily/stem.cc (left):

http://codereview.appspot.com/4922042/diff/17001/lily/stem.cc#oldcode1110
lily/stem.cc:1110: "flag "
restore

http://codereview.appspot.com/4922042/diff/17001/ly/engraver-init.ly
File ly/engraver-init.ly (right):

http://codereview.appspot.com/4922042/diff/17001/ly/engraver-init.ly#newcode678
ly/engraver-init.ly:678: (Voice Flag font-size -3)
also add to make-voice-props-set

http://codereview.appspot.com/4922042/diff/17001/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (left):

http://codereview.appspot.com/4922042/diff/17001/scm/define-grob-properties.scm#oldcode275
scm/define-grob-properties.scm:275: (flag ,ly:stencil? "A function
returning the full flag stencil
move to internal properties and change type-predicate and docstring,
e.g.,

(flag ,ly:grob? "A pointer to a @code{Flag} object.")

http://codereview.appspot.com/4922042/