Re: First stab at getting bar extents right. (issue 5186049)

[pkx166h]

Passes Make, reg check gives me too much to attach as separate pngs.
Attached zipped output here

http://code.google.com/p/lilypond/issues/detail?id=1955#c2

graphviz.log gives me

--snip--
@ -14,9 +14,9 @@
 Writing graph `#f'...digraph G {
 rankdir="LR"
 node [shape=rectangle]
-41 [label="caching Stem.stencil\n# -> #"]
-40 [label="caching LedgerLineSpanner.stencil\n# -> #"]
-39 [label="caching VerticalAxisGroup.stencil\n# -> #f"]
+41 [label="caching LedgerLineSpanner.stencil\n# -> #"]
+40 [label="caching VerticalAxisGroup.stencil\n# -> #f"]
+39 [label="caching Stem.stencil\n# -> #"]
 38 [label="caching StaffSymbol.stencil\n# -> #"]
 37 [label="caching Stem.Y-extent\n# -> (-2.812186 . 0.5)"]
 36 [label="caching Stem.length\n# -> 6.624372"]
@@ -56,7 +56,7 @@
 2 [label="NoteHead\n/home/jlowe/lilypond-git/lily/engraver.cc:60\ncause
<- # 41
+37 -> 39
 36 -> 37
 35 -> 36
 34 -> 35
--snip--

Not sure if that is good or bad.

and input/regression/page-breaking-good-estimation.log

gives me

--snip--

12 +3,12 @@
 Interpreting music...
 Preprocessing graphical objects...
 Finding the ideal number of pages...
-Fitting music on 1 page...
+Fitting music on 1 or 2 pages...
 Drawing systems...
-warning: cannot fit music on page: ragged-spacing was requested, but
page was compressed
 Writing header field `texidoc' to
`/home/jlowe/lilypond-git/build/out/lybook-testdb/58/lily-f9565ccd.texidoc'...
 Layout output to
`/home/jlowe/lilypond-git/build/out/lybook-testdb/58/lily-f9565ccd.eps'...
 Layout output to
`/home/jlowe/lilypond-git/build/out/lybook-testdb/58/lily-f9565ccd-1.eps'...
+Layout output to
`/home/jlowe/lilypond-git/build/out/lybook-testdb/58/lily-f9565ccd-2.eps'...
 Writing
/home/jlowe/lilypond-git/build/out/lybook-testdb/58/lily-f9565ccd-systems.texi...
 Writing
/home/jlowe/lilypond-git/build/out/lybook-testdb/58/lily-f9565ccd-systems.tex...
 Writing
/home/jlowe/lilypond-git/build/out/lybook-testdb/58/lily-f9565ccd-systems.count...

--snip--

James


http://codereview.appspot.com/5186049/