lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fixes footnote automatic numbering. (issue 4877041)


From: hanwenn
Subject: Re: Fixes footnote automatic numbering. (issue 4877041)
Date: Sat, 15 Oct 2011 21:41:20 +0000


http://codereview.appspot.com/4877041/diff/17001/lily/system.cc
File lily/system.cc (left):

http://codereview.appspot.com/4877041/diff/17001/lily/system.cc#oldcode321
lily/system.cc:321: return &footnote_grobs_;
I think you can do this more concisely with the swap() method from the
stl container.

http://codereview.appspot.com/4877041/diff/17001/lily/system.cc
File lily/system.cc (right):

http://codereview.appspot.com/4877041/diff/17001/lily/system.cc#newcode251
lily/system.cc:251: Grob *at_bat = footnote_grobs_[i];
(I have no idea what a 'bat' is supposed to mean.)

http://codereview.appspot.com/4877041/diff/17001/lily/system.cc#newcode322
lily/system.cc:322: grob_2D_less (Grob *g1, Grob *g2)
Describe what this function is doing.  It's not clear from the
implementation.  Better variable names below would also help.

http://codereview.appspot.com/4877041/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]