Re: Fixes footnote automatic numbering. (issue 4877041)

[address@hidden]

On Oct 15, 2011, at 11:41 PM, address@hidden wrote:

http://codereview.appspot.com/4877041/diff/17001/lily/system.cc
File lily/system.cc (left):

http://codereview.appspot.com/4877041/diff/17001/lily/system.cc#oldcode321
lily/system.cc:321: return &footnote_grobs_;
I think you can do this more concisely with the swap() method from the
stl container.

Ok - will change.

http://codereview.appspot.com/4877041/diff/17001/lily/system.cc
File lily/system.cc (right):

http://codereview.appspot.com/4877041/diff/17001/lily/system.cc#newcode251
lily/system.cc:251: Grob *at_bat = footnote_grobs_[i];
(I have no idea what a 'bat' is supposed to mean.)

From American baseball - at bat is the person who will bat.  I find that there is not enough baseball lingo in the source, which is a shame, as it is the sport par excellence from which all other sports derive their legitimacy.

http://codereview.appspot.com/4877041/diff/17001/lily/system.cc#newcode322
lily/system.cc:322: grob_2D_less (Grob *g1, Grob *g2)
Describe what this function is doing.  It's not clear from the
implementation.  Better variable names below would also help.

Will do.  The function determines which grob is higher on the sytem.

http://codereview.appspot.com/4877041/