Re: Adds Scheme function for spring constructor. (issue 5306050)

[dak]

On 2011/10/21 11:27:34, dak wrote:
> http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc
> File lily/spring-smob.cc (left):


http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#oldcode42
> lily/spring-smob.cc:42: return a == b ? SCM_BOOL_T : SCM_BOOL_F;
> On 2011/10/21 11:18:06, Neil Puttock wrote:
> > Not sure why this doesn't use the DEFAULT_EQUAL_P macro.

> I'd use scm_is_eq which is less obscure.  However, I have no idea
whether this
> should not rather be scm_is_true (scm_is_eqv (a, b)) since otherwise
we'll just
> compare for object identity rather than equal values.

> Is object identity sufficient here?

Make that scm_is_true (scm_eqv_p (...

http://codereview.appspot.com/5306050/