lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adds Scheme function for spring constructor. (issue 5306050)


From: bordage . bertrand
Subject: Re: Adds Scheme function for spring constructor. (issue 5306050)
Date: Fri, 21 Oct 2011 11:39:41 +0000


http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc
File lily/spring-smob.cc (left):

http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#oldcode42
lily/spring-smob.cc:42: return a == b ? SCM_BOOL_T : SCM_BOOL_F;
On 2011/10/21 11:27:35, dak wrote:
scm_is_true (scm_is_eqv (a, b))

You mean scm_is_true(scm_eqv_p (a, b))? :)

For me, this function is totally useless.  If we want to check whether
they are equal, we use scm_equal_p, if we want to see whether they are
the same object, we use scm_eqv_p.

Besides, I can't find any use for this function with git grep.

http://codereview.appspot.com/5306050/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]