[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Sketch for in-notes. (issue 5293053)
From: |
percival . music . ca |
Subject: |
Re: Sketch for in-notes. (issue 5293053) |
Date: |
Fri, 21 Oct 2011 23:08:17 +0000 |
http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.cc
File lily/page-breaking.cc (right):
http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.cc#newcode189
lily/page-breaking.cc:189: old.in_note_heights_.begin (),
old.in_note_heights_.end ());
Why are we talking about C++ style?
Run it through fix-cc.py. Whatever that produces is ok as far as this
patch goes.
(if something looks bad, then we can discuss modifying fix-cc.py in some
way -- but that's a separate issue from whether we accept this patch or
not.)
http://codereview.appspot.com/5293053/
- Sketch for in-notes. (issue 5293053), mtsolo, 2011/10/20
- Re: Sketch for in-notes. (issue 5293053), mtsolo, 2011/10/20
- Re: Sketch for in-notes. (issue 5293053), mtsolo, 2011/10/20
- Re: Sketch for in-notes. (issue 5293053), bordage . bertrand, 2011/10/21
- Re: Sketch for in-notes. (issue 5293053), mtsolo, 2011/10/21
- Re: Sketch for in-notes. (issue 5293053), bordage . bertrand, 2011/10/21
- Re: Sketch for in-notes. (issue 5293053), bordage . bertrand, 2011/10/21
- Re: Sketch for in-notes. (issue 5293053),
percival . music . ca <=
- Re: Sketch for in-notes. (issue 5293053), n . puttock, 2011/10/21
- Re: Sketch for in-notes. (issue 5293053), dak, 2011/10/21
- Re: Sketch for in-notes. (issue 5293053), bordage . bertrand, 2011/10/21
- Re: Sketch for in-notes. (issue 5293053), dak, 2011/10/21
- Re: Sketch for in-notes. (issue 5293053), n . puttock, 2011/10/28
- Re: Sketch for in-notes. (issue 5293053), dak, 2011/10/29