Re: Sketch for in-notes. (issue 5293053)

[dak]

On 2011/10/28 13:26:22, mike_apollinemike.com wrote:
> On Oct 28, 2011, at 3:24 PM, mailto:address@hidden wrote:

> >
> >

http://codereview.appspot.com/5293053/diff/11005/input/regression/footnote-break-visibility.ly
> > File input/regression/footnote-break-visibility.ly (left):
> >
> >

http://codereview.appspot.com/5293053/diff/11005/input/regression/footnote-break-visibility.ly#oldcode1
> > input/regression/footnote-break-visibility.ly:1: \version "2.14.0"
> > 2.15.17
> >
> >
http://codereview.appspot.com/5293053/diff/11005/input/regression/in-note.ly
> > File input/regression/in-note.ly (right):
> >
> >

http://codereview.appspot.com/5293053/diff/11005/input/regression/in-note.ly#newcode1
> > input/regression/in-note.ly:1: \version "2.15.15"
> > 2.15.17
> >
> >

http://codereview.appspot.com/5293053/diff/11005/input/regression/in-note.ly#newcode5
> > input/regression/in-note.ly:5: be above or below the staff via the
paper
> > variable @code{in note direction}
> > You reference these properties without testing them (and the first
is
> > missing hyphens).
> >
> >

http://codereview.appspot.com/5293053/diff/11005/input/regression/in-note.ly#newcode6
> > input/regression/in-note.ly:6: and spaced via the variable
> > @{in-note-padding}.
> > address@hidden
> >
> >
http://codereview.appspot.com/5293053/diff/11005/lily/constrained-breaking.cc
> > File lily/constrained-breaking.cc (right):
> >
> >

http://codereview.appspot.com/5293053/diff/11005/lily/constrained-breaking.cc#newcode561
> > lily/constrained-breaking.cc:561: programming_error ("expecting
stencil,
> > got empty pointer");
> > if you get a null pointer, you can't dereference it in the next line
> >
> >
http://codereview.appspot.com/5293053/diff/11005/lily/page-layout-problem.cc
> > File lily/page-layout-problem.cc (left):
> >
> >

http://codereview.appspot.com/5293053/diff/11005/lily/page-layout-problem.cc#oldcode72
> > lily/page-layout-problem.cc:72: itself be comprised of several
> > footnotes.
> > may itself comprise several
> >
> >
http://codereview.appspot.com/5293053/diff/11005/lily/page-layout-problem.cc
> > File lily/page-layout-problem.cc (right):
> >
> >

http://codereview.appspot.com/5293053/diff/11005/lily/page-layout-problem.cc#newcode88
> > lily/page-layout-problem.cc:88: programming_error ("Footnotes must
be
> > added to lines before they're retrieved.");
> > they are
> >
> >

http://codereview.appspot.com/5293053/diff/11005/scm/define-grob-properties.scm
> > File scm/define-grob-properties.scm (right):
> >
> >

http://codereview.appspot.com/5293053/diff/11005/scm/define-grob-properties.scm#newcode1043
> > scm/define-grob-properties.scm:1043: (in-note-padding ,number?
"Padding
> > between in notes.")
> > in-notes
> >
> >
http://codereview.appspot.com/5293053/diff/11005/scm/paper-system.scm
> > File scm/paper-system.scm (right):
> >
> >

http://codereview.appspot.com/5293053/diff/11005/scm/paper-system.scm#newcode38
> > scm/paper-system.scm:38: (let* ((main-stencil (ly:prob-property
system
> > 'stencil))
> > let

> Hey Neil,

> You caught the patch post-push.  I'll incorporate these comments into
a new
> patch and post it to the list w/in the next 72ish hours.
> In general, I have no problem holding off on pushing something if you
send me a
> note saying "I'll have time in X # of days to give comments - please
wait."

> Cheers,
> MS

Patch has been backed out.  It broke the documentation build this
morning.  And it broke the documentation build with a line that Neil has
already pointed out yesterday at noon.  It is not that this particular
mistake was unheard of.

Since this kept the second in unfriendliness from accepting a patch
series from the most unfriendly developer, consider the remarks to be
expected as having been made.

I have not checked in this particular instance, but in my experience
"make doc-clean info" detects most documentation building failures while
appearing somewhat faster than a web build.

http://codereview.appspot.com/5293053/