[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Sketch for in-notes. (issue 5293053)
From: |
address@hidden |
Subject: |
Re: Sketch for in-notes. (issue 5293053) |
Date: |
Sat, 22 Oct 2011 21:56:16 +0200 |
On Oct 22, 2011, at 1:08 AM, address@hidden wrote:
>
> http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.cc
> File lily/page-breaking.cc (right):
>
> http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.cc#newcode189
> lily/page-breaking.cc:189: old.in_note_heights_.begin (),
> old.in_note_heights_.end ());
> Why are we talking about C++ style?
>
> Run it through fix-cc.py. Whatever that produces is ok as far as this
> patch goes.
> (if something looks bad, then we can discuss modifying fix-cc.py in some
> way -- but that's a separate issue from whether we accept this patch or
> not.)
>
> http://codereview.appspot.com/5293053/
Running fix-cc.py, I got:
page-layout-problem.cc...
Invalid command line option: align-pointer=name
For help on options, type 'astyle -h'
astyle wasn't in the lilydev Ubuntu, so I used apt-get to get it. Maybe
there's a problem with versioning?
Cheers,
MS
- Sketch for in-notes. (issue 5293053), mtsolo, 2011/10/20
- Re: Sketch for in-notes. (issue 5293053), mtsolo, 2011/10/20
- Re: Sketch for in-notes. (issue 5293053), mtsolo, 2011/10/20
- Re: Sketch for in-notes. (issue 5293053), bordage . bertrand, 2011/10/21
- Re: Sketch for in-notes. (issue 5293053), mtsolo, 2011/10/21
- Re: Sketch for in-notes. (issue 5293053), bordage . bertrand, 2011/10/21
- Re: Sketch for in-notes. (issue 5293053), bordage . bertrand, 2011/10/21
- Re: Sketch for in-notes. (issue 5293053), percival . music . ca, 2011/10/21
- Re: Sketch for in-notes. (issue 5293053),
address@hidden <=
- Re: Sketch for in-notes. (issue 5293053), n . puttock, 2011/10/21
- Re: Sketch for in-notes. (issue 5293053), dak, 2011/10/21
- Re: Sketch for in-notes. (issue 5293053), bordage . bertrand, 2011/10/21
- Re: Sketch for in-notes. (issue 5293053), dak, 2011/10/21
- Re: Sketch for in-notes. (issue 5293053), n . puttock, 2011/10/28
- Re: Sketch for in-notes. (issue 5293053), dak, 2011/10/29