[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Caches pure translations for full score. (issue 5349043)
|
From: |
joeneeman |
|
Subject: |
Re: Caches pure translations for full score. (issue 5349043) |
|
Date: |
Sat, 05 Nov 2011 20:36:32 +0000 |
looks good! I never realized this case was such a bottleneck.
http://codereview.appspot.com/5349043/diff/1/lily/align-interface.cc
File lily/align-interface.cc (right):
http://codereview.appspot.com/5349043/diff/1/lily/align-interface.cc#newcode320
lily/align-interface.cc:320: SCM l = SCM_EOL;
Given that you've gone to the trouble of writing float_list_to_vector,
maybe you could also write float_vector_to_list. And I think they belong
somewhere more public, too.
http://codereview.appspot.com/5349043/