Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

[address@hidden]

On Nov 8, 2011, at 10:16 PM, address@hidden wrote:

> 
> http://codereview.appspot.com/5323062/diff/39005/lily/pure-from-neighbor-engraver.cc
> File lily/pure-from-neighbor-engraver.cc (right):
> 
> http://codereview.appspot.com/5323062/diff/39005/lily/pure-from-neighbor-engraver.cc#newcode60
> lily/pure-from-neighbor-engraver.cc:60: pure_relevants_.push_back
> (i.item ());
> It seems that pure_relevants_[] are the grobs that have the
> pure-from-neighbor interface, which would be the BarLines, Clefs,
> SpanBarStubs etc.
> This is a disjoint set from item_[].
> All of item_[] satisfy (pure-relevant? x)
> Not all of pure_relevants_[] satisfy (pure-relevant? x)
> 
> The variable naming is evil.

You're right...brain fart on my part.  Fixed.

> 
> http://codereview.appspot.com/5323062/diff/39005/scm/define-grobs.scm
> File scm/define-grobs.scm (right):
> 
> http://codereview.appspot.com/5323062/diff/39005/scm/define-grobs.scm#newcode1743
> scm/define-grobs.scm:1743: (pure-from-neighbor-ignore . #t)
> Scripts can be wide enough to hit span bars.
> What good does pure-from-neighbor-ignore do ?
> The behavior is surprising.  Playing with the example you gave earlier
> :
> \new GrandStaff <<
> \new Staff R1*5
> \new Staff {
>   \override TextScript #'extra-spacing-width = ##f
>   dis4 dis dis dis^"sliding-over" |
>   dis4 dis dis dis |
>   dis'''4 dis dis dis^"sliding-over-not" | R1
>   c'''4\espressivo  a'2. } >>
> 

You're also right.  I blame lack of sleep.  I got rid of this property and now 
everything plays as expected.

Cheers,
MS