Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

[k-ohara5a5a]

Until someone comes along who understands this, I'll display my
confusions.


http://codereview.appspot.com/5323062/diff/28002/lily/pure-from-neighbor-interface.cc
File lily/pure-from-neighbor-interface.cc (right):

http://codereview.appspot.com/5323062/diff/28002/lily/pure-from-neighbor-interface.cc#newcode84
lily/pure-from-neighbor-interface.cc:84: // uses drul array for grace
(LEFT) vs. not grace (RIGHT).
Why use a drul array instead of just an array from 0 (false) to 1 (true)
indexed by your boolean 'has_grace' ?

http://codereview.appspot.com/5323062/diff/28002/lily/pure-from-neighbor-interface.cc#newcode96
lily/pure-from-neighbor-interface.cc:96: && (grace == LEFT ? has_grace :
!has_grace))
In fact, why even use a loop over grace-ness if the actions within the
loop occur only for one of two passes through ?

http://codereview.appspot.com/5323062/diff/28002/lily/pure-from-neighbor-interface.cc#newcode113
lily/pure-from-neighbor-interface.cc:113: if (d * srl_drul[LEFT][d] < d
* srl_drul[RIGHT][d])
This seems to say "if the closest grace-note-column is closer than the
closest non-grace-column, include the stuff in the grace-note-column in
my 'neighbors'".
Why are you treating grace-note columns specially ?

http://codereview.appspot.com/5323062/