Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

[k-ohara5a5a]

Works nicely.

I'm inspired to name some variables in Irish now!  And, I'll be sure the
names are misleadingly related, but critically distinct, from the
conceptual contents of the variable.


http://codereview.appspot.com/5440049/diff/1/lily/bar-number-engraver.cc
File lily/bar-number-engraver.cc (right):

http://codereview.appspot.com/5440049/diff/1/lily/bar-number-engraver.cc#newcode38
lily/bar-number-engraver.cc:38: int renvoi_number_;
maybe "alternative_number_"
Isn't there already a counter for that somewhere?
Nested \alternatives fool it, but I couldn't make it crash so that
should be fine.

http://codereview.appspot.com/5440049/diff/1/lily/bar-number-engraver.cc#newcode64
lily/bar-number-engraver.cc:64: SCM renvoi_dir_scm = context
()->get_property ("renvoiDir");
maybe "FirstOrLastAlternative"
I guess you made it a direction for type-checking purposes?

http://codereview.appspot.com/5440049/diff/1/lily/bar-number-engraver.cc#newcode65
lily/bar-number-engraver.cc:65: SCM renvoi_style = context
()->get_property ("renvoiStyle");
"AlternateNumberingStyle"

http://codereview.appspot.com/5440049/diff/1/lily/include/timing-translator.hh
File lily/include/timing-translator.hh (right):

http://codereview.appspot.com/5440049/diff/1/lily/include/timing-translator.hh#newcode28
lily/include/timing-translator.hh:28: int renvoi_;
maybe "alternative_starting_bar_number"

http://codereview.appspot.com/5440049/diff/1/lily/timing-translator.cc
File lily/timing-translator.cc (right):

http://codereview.appspot.com/5440049/diff/1/lily/timing-translator.cc#newcode85
lily/timing-translator.cc:85: bool make_renvoi = context
()->get_property ("renvoiStyle") == ly_symbol2scm
("repeat-measure-numbers")
"numbers"

http://codereview.appspot.com/5440049/diff/1/lily/timing-translator.cc#newcode86
lily/timing-translator.cc:86: || context ()->get_property
("renvoiStyle") == ly_symbol2scm
("repeat-measure-numbers-with-letter-tags");
"numbers-with-letters"

http://codereview.appspot.com/5440049/diff/1/lily/timing-translator.cc#newcode90
lily/timing-translator.cc:90: if (renvoi_dir == -1)
Desperately seeking comment.

http://codereview.appspot.com/5440049/diff/1/scm/define-music-properties.scm
File scm/define-music-properties.scm (right):

http://codereview.appspot.com/5440049/diff/1/scm/define-music-properties.scm#newcode174
scm/define-music-properties.scm:174: (renvoi-dir ,ly:dir? "The direction
of a volta send-back.")
Seems more like: indicates if an AlternativeStart event is the
First (-1), Middle (0), Last (1)
of group of alternate endings.

http://codereview.appspot.com/5440049/diff/1/scm/define-music-types.scm
File scm/define-music-types.scm (right):

http://codereview.appspot.com/5440049/diff/1/scm/define-music-types.scm#newcode453
scm/define-music-types.scm:453: (RenvoiMusic
maybe "AlternativeStart"
Does it need an iterator? does it contain the alternative or is it
merely an event marking the start?

http://codereview.appspot.com/5440049/