Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

[mtsolo]

I'll just say to all you haters of `renvoi' that:

--) There is no English term that I know of that succinctly expresses
the idea of "being sent back to something."  And, as new terms are
invented out of necessity, I took the liberty to invent one here with
`renvoi,' which Jankélévitch (musicologist) uses all the time to evoke a
notion of "going back to" with cryptic phrases like "La mort propre est
un renvoi de l'au-delà à l'en deçà." (One's own death is a send-back
from the great beyond to corporeal reality,) (NB this is not a real
Jankélévitch quote...but it may as well have been...).
--) Renvoi also means `belch'.  For this reason alone it deserves to be
part of the source.

But, deferring to the clamors of my detractors, I have changed it.

Regtest changed a bit too and all other comments summarily responded to.

The only problem that remains is that the display-lily-tests shows a
one-space increase in the new output.  I've made the string rendered for
AlternativeEvent "", but is there any way just to get the display method
to ignore it (meaning not add the extra whitespace)?  If not, this extra
whitespace doesn't bother me and I'll add it as "NOT A BUG", but I'd
rather scrub it if possible.

Cheers,
MS


http://codereview.appspot.com/5440049/diff/1/lily/bar-number-engraver.cc
File lily/bar-number-engraver.cc (right):

http://codereview.appspot.com/5440049/diff/1/lily/bar-number-engraver.cc#newcode38
lily/bar-number-engraver.cc:38: int renvoi_number_;
On 2011/11/29 03:54:42, Keith wrote:
> maybe "alternative_number_"
> Isn't there already a counter for that somewhere?
> Nested \alternatives fool it, but I couldn't make it crash so that
should be
> fine.

Done.

http://codereview.appspot.com/5440049/diff/1/lily/bar-number-engraver.cc#newcode64
lily/bar-number-engraver.cc:64: SCM renvoi_dir_scm = context
()->get_property ("renvoiDir");
On 2011/11/29 03:54:42, Keith wrote:
> maybe "FirstOrLastAlternative"
> I guess you made it a direction for type-checking purposes?

Done.

http://codereview.appspot.com/5440049/diff/1/lily/bar-number-engraver.cc#newcode65
lily/bar-number-engraver.cc:65: SCM renvoi_style = context
()->get_property ("renvoiStyle");
On 2011/11/29 03:54:42, Keith wrote:
> "AlternateNumberingStyle"

Done.

http://codereview.appspot.com/5440049/diff/1/lily/include/timing-translator.hh
File lily/include/timing-translator.hh (right):

http://codereview.appspot.com/5440049/diff/1/lily/include/timing-translator.hh#newcode28
lily/include/timing-translator.hh:28: int renvoi_;
On 2011/11/29 03:54:42, Keith wrote:
> maybe "alternative_starting_bar_number"

Done.

http://codereview.appspot.com/5440049/diff/1/lily/timing-translator.cc
File lily/timing-translator.cc (right):

http://codereview.appspot.com/5440049/diff/1/lily/timing-translator.cc#newcode85
lily/timing-translator.cc:85: bool make_renvoi = context
()->get_property ("renvoiStyle") == ly_symbol2scm
("repeat-measure-numbers")
On 2011/11/29 03:54:42, Keith wrote:
> "numbers"

Done.

http://codereview.appspot.com/5440049/diff/1/lily/timing-translator.cc#newcode86
lily/timing-translator.cc:86: || context ()->get_property
("renvoiStyle") == ly_symbol2scm
("repeat-measure-numbers-with-letter-tags");
On 2011/11/29 03:54:42, Keith wrote:
> "numbers-with-letters"

Done.

http://codereview.appspot.com/5440049/diff/1/lily/timing-translator.cc#newcode90
lily/timing-translator.cc:90: if (renvoi_dir == -1)
On 2011/11/29 03:54:42, Keith wrote:
> Desperately seeking comment.

Done.

http://codereview.appspot.com/5440049/diff/1/lily/timing-translator.cc#newcode172
lily/timing-translator.cc:172: "renvoiDir "
On 2011/11/29 00:04:52, Carl wrote:
> I'm not comfortable at this point with the names renvoiDir and
renvoiStyle.
> What do you mean by renvoi?

> The Virginia Tech online music dictionary has no entry for renvoi.
The
> Dolmetsch online dictionary lists renvoi as the repeat sign to which
dal segno
> refers.  renvoi to me appears to be a french word that carries very
little, if
> any, english meaning.  But I'm not a music professional, so perhaps
I'm all wet
> on this one.

> I would expect something more like alternativeBarNumberStyle.  And I
don't know
> what alternative I would propose for renvoiDir, since I don't really
grok its
> meaning right now.

Done.

http://codereview.appspot.com/5440049/diff/1/scm/define-context-properties.scm
File scm/define-context-properties.scm (right):

http://codereview.appspot.com/5440049/diff/1/scm/define-context-properties.scm#newcode416
scm/define-context-properties.scm:416: (renvoiDir ,ly:dir? "The
direction of a volta send-back.")
On 2011/11/29 00:04:52, Carl wrote:
> What are the possibilities of directions?  Can it be either backward
or forward
> in time?  Is that why we need renvoiDir?

> What is a "volta send-back"?

LEFT is the beginning of an alternative
CENTER is each time the alternative repeats
RIGHT is the end of an alternative

It is true that Direction is a bit of a stretch to use directions in
this case, but I'm using them because they correspond to left->right in
score space and are easier than defining a new enum (or enum-like
convention of naming scheme variables).  I may have to fiddle with this
to address Keith's concern about combined volta repeats and skipping
letters.

http://codereview.appspot.com/5440049/diff/1/scm/define-context-properties.scm#newcode417
scm/define-context-properties.scm:417: (renvoiStyle ,symbol? "The style
of a volta send-back.")
On 2011/11/29 00:04:52, Carl wrote:
> What are the possible styles, and where are they documented?

Thanks for spotting this - I'll document them here.

http://codereview.appspot.com/5440049/diff/1/scm/define-music-properties.scm
File scm/define-music-properties.scm (right):

http://codereview.appspot.com/5440049/diff/1/scm/define-music-properties.scm#newcode110
scm/define-music-properties.scm:110: (last-renvoi ,ly:dir? "Is this the
last send-back for a volta.")
On 2011/11/29 00:04:52, Carl wrote:
> The property description indicates a boolean value.  But the type
indicates a
> direction (as in renvoi-dir.  Is this supposed to be a boolean, or is
it
> supposed to be a direction?

Vestigial, removing.

http://codereview.appspot.com/5440049/diff/1/scm/define-music-properties.scm#newcode174
scm/define-music-properties.scm:174: (renvoi-dir ,ly:dir? "The direction
of a volta send-back.")
On 2011/11/29 03:54:42, Keith wrote:
> Seems more like: indicates if an AlternativeStart event is the
> First (-1), Middle (0), Last (1)
> of group of alternate endings.

Done.

http://codereview.appspot.com/5440049/diff/1/scm/define-music-types.scm
File scm/define-music-types.scm (right):

http://codereview.appspot.com/5440049/diff/1/scm/define-music-types.scm#newcode453
scm/define-music-types.scm:453: (RenvoiMusic
On 2011/11/29 03:54:42, Keith wrote:
> maybe "AlternativeStart"
> Does it need an iterator? does it contain the alternative or is it
merely an
> event marking the start?

You're right - it's an event now.

http://codereview.appspot.com/5440049/