lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adds support for cross-staff-stems (issue 6344092)


From: tdanielsmusic
Subject: Re: Adds support for cross-staff-stems (issue 6344092)
Date: Mon, 09 Jul 2012 21:38:13 +0000

I don't think all these functions should be in
ly/music-functions-init.ly, but I don't know the best place for them.
Someone more familiar with the layout of code may advise.  The one
function that should be here is the one you asked about in your earlier
mail - crossStaff.

Trevor


http://codereview.appspot.com/6344092/diff/1/Documentation/snippets/new/cross-staff-stems.ly
File Documentation/snippets/new/cross-staff-stems.ly (right):

http://codereview.appspot.com/6344092/diff/1/Documentation/snippets/new/cross-staff-stems.ly#newcode19
Documentation/snippets/new/cross-staff-stems.ly:19: <<
<< and matching >> are not required; remove

http://codereview.appspot.com/6344092/diff/1/Documentation/snippets/new/cross-staff-stems.ly#newcode22
Documentation/snippets/new/cross-staff-stems.ly:22: <<
Only one voice, better to use { .. }

http://codereview.appspot.com/6344092/diff/1/Documentation/snippets/new/cross-staff-stems.ly#newcode31
Documentation/snippets/new/cross-staff-stems.ly:31: <<
Only one voice, better to use { .. }

http://codereview.appspot.com/6344092/diff/1/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/6344092/diff/1/ly/music-functions-init.ly#newcode327
ly/music-functions-init.ly:327: #(define-music-function (parser location
notes) (ly:music?) #{
As I said earlier, this function needs a doc string

http://codereview.appspot.com/6344092/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]