Re: parenthesizeStencil and bracketifyStencil (issue 6397043)

[Phil Holmes]

----- Original Message ----- 
From: "Thomas Morley" <address@hidden>
To: <address@hidden>
Cc: <address@hidden>; <address@hidden>
Sent: Friday, July 13, 2012 10:17 PM
Subject: Re: parenthesizeStencil and bracketifyStencil (issue 6397043)


> 2012/7/13  <address@hidden>:
> > Reviewers: ,
> >
> > Message:
> > please review
> >
> > Description:
> > parenthesizeStencil and bracketifyStencil
> >
> > Issue 2646
> >
> > These function can parenthesize/bracketify nearly all kind of stencils.
> >
> > Please review this at http://codereview.appspot.com/6397043/
> >
> > Affected files:
> >   M Documentation/ly-examples/aucun-snippet.ly
> >   A input/regression/parenthesizeStencil-bracketifyStencil.ly
> >   M ly/music-functions-init.ly
> >   M scm/define-markup-commands.scm
> >   M scm/stencil.scm
>
> This patch will break two other files:
> /Documentation/snippets/time-signature-in-parentheses---method-3.ly
> /Documentation/snippets/time-signature-in-parentheses.ly
>
> Fixing these files is very easy.
> But after reading the in-file-comment:
>
> %% DO NOT EDIT this file manually; it is automatically
> %% generated from LSR http://lsr.dsi.unimi.it
> %% Make any changes in LSR itself, or in Documentation/snippets/new/ ,
> %% and then run scripts/auxiliar/makelsr.py
>
> I wasn't sure what to do.


Kind of what it says.  Files in /Documentation/snippets/ are not a permanent 
feature of the source - they get updated from the LSR whenever the 
LRS-meister grabs a tarball from the LSR and uses it to update the snippets. 
So - if your changes will break the snippet, but will only work in in future 
versions, copy the snippet to snippets/new and update it there.  Otherwise, 
update the snippet by editing the LSR.

--
Phil Holmes