lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: span-bar-engraver.cc: Sort staves in vertical order, orphans last (i


From: Marc Hohl
Subject: Re: span-bar-engraver.cc: Sort staves in vertical order, orphans last (issue 6406051)
Date: Sat, 21 Jul 2012 10:07:09 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0

Am 20.07.2012 23:43, schrieb Keith OHara:
On Fri, 20 Jul 2012 11:38:34 -0700, Marc Hohl <address@hidden> wrote:

I think that my current redefinition already includes the sorting
(see lines 578/579 of
http://codereview.appspot.com/6305115/diff/30001/scm/bar-line.scm)

I don't read Scheme, but it does seem to function properly.

so perhaps this patch could be postponed until

http://codereview.appspot.com/6305115/

is accepted? Then only the regtest would be needed.

It is easier for me to push the fix along with the regtest, than to remember to push the regtest later. Also, pushing the bug fix separately from your re-implementation gives us a bug-free point in the history of the code, to which we can return if we discover a problem with the re-implementation.


Ok, sounds reasonable.

Marc



reply via email to

[Prev in Thread] Current Thread [Next in Thread]