[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: push patch for issue 2679
From: |
David Kastrup |
Subject: |
Re: push patch for issue 2679 |
Date: |
Tue, 24 Jul 2012 18:50:52 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) |
David Nalesnik <address@hidden> writes:
> On Tue, Jul 24, 2012 at 11:34 AM, Graham Percival
> <address@hidden> wrote:
>
> On Tue, Jul 24, 2012 at 05:26:01PM +0100, Phil Holmes wrote:
> > I'd be happy to push this, but would like a little advice. If I
> > go to Rietveld and download the raw patch set, it comes without
> > proper email addresses and formatting. This means to push stuff
> > from Rietveld, I have to git apply the diff, then manually
> > update the author (assuming I remember). Is there a way of
> > getting a formatted patch?
>
>
> Don't apply things directly from Rietveld. Due to the problems
> that you discovered, we can only use it as a reviewing tool, not a
> patch management tool.
>
> David Nalesnik should send you the file he gets from
> git format-patch, after he fixed all merge conflicts etc.
>
>
> Arggh...sorry for making a hash of this :( Hopefully, this patch will
> be properly formatted...
Yup. A matter of personal taste (you can do that just with git commit
--amend): the commit message is
[PATCH] Function for overriding broken spanners
We don't commit anything other than patches. That's redundant. But
Issue 2679: Function for overriding broken spanners
would make it easier to find the corresponding issue in case one needs
to revisit the commit at one point of time.
--
David Kastrup
- Re: push patch for issue 2679, (continued)
- Re: push patch for issue 2679, David Nalesnik, 2012/07/24
- Re: push patch for issue 2679, David Kastrup, 2012/07/24
- Re: push patch for issue 2679, David Nalesnik, 2012/07/24
- Re: push patch for issue 2679, David Kastrup, 2012/07/24
- Re: push patch for issue 2679, David Nalesnik, 2012/07/24
- Re: push patch for issue 2679, David Nalesnik, 2012/07/24
- Re: push patch for issue 2679, Phil Holmes, 2012/07/24
- Re: push patch for issue 2679, David Kastrup, 2012/07/24
- Re: push patch for issue 2679, Graham Percival, 2012/07/24
- Re: push patch for issue 2679, David Nalesnik, 2012/07/24
- Re: push patch for issue 2679,
David Kastrup <=
- Re: push patch for issue 2679, David Nalesnik, 2012/07/24
- Re: push patch for issue 2679, David Kastrup, 2012/07/24
- Re: push patch for issue 2679, Graham Percival, 2012/07/24
- Re: push patch for issue 2679, David Kastrup, 2012/07/24
- Re: push patch for issue 2679, David Nalesnik, 2012/07/24
- Re: push patch for issue 2679, Phil Holmes, 2012/07/24
- Re: push patch for issue 2679, David Nalesnik, 2012/07/24
- Re: push patch for issue 2679, Phil Holmes, 2012/07/24
- Re: push patch for issue 2679, David Kastrup, 2012/07/24
- Re: push patch for issue 2679, David Nalesnik, 2012/07/24