lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GOP2-4 - C++ and scheme indentation


From: David Kastrup
Subject: Re: GOP2-4 - C++ and scheme indentation
Date: Thu, 09 Aug 2012 13:34:22 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)

Graham Percival <address@hidden> writes:

> On Thu, Aug 09, 2012 at 01:08:42PM +0200, David Kastrup wrote:
>> 
>> The stumbling block is _writing_ the Scheme code, not submitting it.
>> When is the last time a code review complained about Scheme code
>> formatting?
>
> I gave URLs in the proposal, but here you go:
> http://codereview.appspot.com/5343050/#msg1
> http://codereview.appspot.com/5343050/#msg5
> (note that there were 3 or 4 different rietveld issues discussing
> that particular patchset, so previous discussion is not on that
> page)

The submitter _reformatted_ existing code with different conventions.
His own work was not put into question as far as I can see.

> That's not necessarily the last time, but it was within the past
> year, and it royally screwed over a new contributor.

I don't see that picking some rules will change the perspectives of
gratuitous changes significantly.

-- 
David Kastrup




reply via email to

[Prev in Thread] Current Thread [Next in Thread]